Add firstPatchedVersion in github API - #748
Merged
Merged
Conversation
TG1999
force-pushed
the
first_patched_version_github
branch
from
May 21, 2022 12:49
10d6977 to
d07eabe
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
first_patched_version_github
branch
from
May 21, 2022 13:02
d07eabe to
6e974c8
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
pombredanne
reviewed
May 24, 2022
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
pombredanne
approved these changes
May 24, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM... Please double check the get item() , may be to ensure you have corner cases testsed.
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
first_patched_version_github
branch
from
May 24, 2022 12:18
00c053d to
0f3404b
Compare
Contributor
Author
|
Thanks! added tests for the corner cases, merging now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub importer failed to parse Composer packages who did not have a slash in their names. We now no longer raise an exception if a Composer package does not have "vendor/name" but only a plain name.
Also we were not getting the first patched version from the GitHub API using GraphQL. This PR is also fixing this.
Reference: #645
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com